Skip to content

fix: NetworkAnimator not synchronizing changes to layer weights#2399

Merged
NoelStephensUnity merged 6 commits intodevelopfrom
fix/networkanimator-not-synchronizing-changes-in-layer-weights
Feb 2, 2023
Merged

fix: NetworkAnimator not synchronizing changes to layer weights#2399
NoelStephensUnity merged 6 commits intodevelopfrom
fix/networkanimator-not-synchronizing-changes-in-layer-weights

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

This resolves the issue where layer weights were not being updated unless a state transition was occurring.
MTT-5389

Changelog

  • Fixed: Issue where changes to a layer's weight would not synchronize unless a state transition was occurring.

Testing and Documentation

  • Includes integration tests additions.

This resolves the regression bug where layer weight updates were not being synchronized if no state transition was ocurring.
MTT-5389
Adding test to verify layer weight changes are updated for connected clients and that late joining clients are synchronized to the updated weight value.
Adding small manual test adjustment to verify the change in a layer weight is synchronized.
MTT-5389
Adding changelog entry.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review January 31, 2023 20:27
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner January 31, 2023 20:27
NoelStephensUnity and others added 2 commits January 31, 2023 14:38
Adding the assert on timeout after the late joined client check occurs.
{
if (!IsOwner && IsSpawned)
{
if (Input.GetKeyDown(KeyCode.Alpha4))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like debug code maybe?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is part of the manual test that just allows you to verify that when changes are applied to a layer's weight that it was updated on other non-authoritative/owner instances.

BeginAttack(2);
}

if (Input.GetKeyDown(KeyCode.Alpha3))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is part of the manual test that just allows you to verify that when changes are applied to a layer's weight that it was updated on other non-authoritative/owner instances.

@NoelStephensUnity NoelStephensUnity merged commit 5f1b0ed into develop Feb 2, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/networkanimator-not-synchronizing-changes-in-layer-weights branch February 2, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants